Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret ExternalImpulse/ExternalForce torque in correct units #492

Closed
wants to merge 2 commits into from

Conversation

GinjaNinja32
Copy link

force (kg m s⁻²) gets scaled down when passing to rapier
torque (kg m² s⁻²) should also be scaled down by a factor of scale²

without this change, there is AFAICT no combination of units that can be passed to ExternalImpulse::at_point/ExternalForce::at_point to give both correctly-acting force and torque with a non-1.0 scale; with this change, passing all values in scale units results in an impulse/force also in scale units, which is then correctly scaled before being passed to rapier.

@GinjaNinja32
Copy link
Author

no combination of units that can be passed [...] to give both correctly-acting force and torque with a non-1.0 scale

i was slightly wrong here, but it's silly; if you pass force/impulse in scale units and point/center_of_mass in inverse scale units, you get numbers out such that the linear force/impulse is in scale units and the torque is in SI. it'd be super weird to do the conversion, but it is technically possible.

@Vrixyz Vrixyz added D-Medium P-High arbitrary important item labels May 20, 2024
@sebcrozet
Copy link
Member

This should no longer be relevant since we don’t scale internal rapier structures based on the physics-scale/length unit any more. So the user is expected to provide force/torque taking into account their custom units.

@sebcrozet sebcrozet closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Medium P-High arbitrary important item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants