Interpret ExternalImpulse/ExternalForce torque in correct units #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force (kg m s⁻²) gets scaled down when passing to rapier
torque (kg m² s⁻²) should also be scaled down by a factor of scale²
without this change, there is AFAICT no combination of units that can be passed to
ExternalImpulse::at_point
/ExternalForce::at_point
to give both correctly-acting force and torque with a non-1.0 scale; with this change, passing all values in scale units results in an impulse/force also in scale units, which is then correctly scaled before being passed to rapier.