Update to Bevy 0.10 #324
Merged
Update to Bevy 0.10 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rederick29
reviewed
Feb 14, 2023
11 tasks
|
Bevy 0.10 will now use glam 0.23. Should probably upgrade here too. Related #331 |
SET001
reviewed
Mar 4, 2023
4 tasks
mnmaita
reviewed
Mar 7, 2023
| @@ -72,20 +72,23 @@ pub fn setup_physics(mut commands: Commands) { | |||
|
|
|||
| fn cast_ray( | |||
| mut commands: Commands, | |||
| windows: Res<Windows>, | |||
| windows: Query<&Window>, | |||
There was a problem hiding this comment.
Should you add With<PrimaryWindow> filter here to keep the previous behavior? I see you were calling get_primary() to get the window.
There was a problem hiding this comment.
Sorry, I merged right before seeing your comment. I think this is a good point. I’ll make the change with the release.
There was a problem hiding this comment.
The example already didn't support multiple windows so it's effectively the same.
I just followed what Bevy's examples do, but I'll leave it up to seb
There was a problem hiding this comment.
No worries! I'm anxious for this new release tbh. 😆
Thanks everyone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetectDespawnwas removed. It existed to make sure that removed components were not missed. This should no longer be an issue asRemovedComponentsis now backed by anEvents<T>which keeps the events around for an extra frame.Supercedes #331
Tasks
custom_system_setup3physics_scalesetting (Opened issue Higherphysics_scalesetting causes rigidbodies to sleep when they shouldn't #338). I've removed it from the example since it's 3Dasync_scene_collider_initializestest that fails/succeeds randomly