Per entity/collider debug rendering #278
Conversation
There was a problem hiding this comment.
Looks like it would work, but it could use a little bit of cleanup.
Is there any way to elevate "draw only entities with ColliderDebug components" to a system, and have a global system and a selective one, and bail out at the start of either, instead of doing this per-line?
| self.global || self.visible.contains(entity) | ||
| }) | ||
| .unwrap_or(false), | ||
| _ => true, |
There was a problem hiding this comment.
Does this _ => true imply that only collider rendering can ever be disabled per-entity, and everything else remains on?
There was a problem hiding this comment.
Well that's what I'm using at the moment, colliders only, so I wasn't even sure if joints are rendered ? And for the bodies, I guess it's only the axes thing that is rendered. But what is DebugRenderObject::Other ?.. And how would I render joints, only if two bodies are marked as debug-visible ? Or any of two bodies is enough to be rendered
I think no, there is no way. Well I don't see any, since rendering is done by |
|
Overall a good idea/impl imo :) I think adding a per-entity "DebugRenderMode" would be useful in the future as well, but I think getting this in first would be preferable. |
|
I have updated this PR once again, I wonder if anything is blocking this PR from being merged ? Would really like to get this feature into the library ! |
barsoosayque
force-pushed
the
debug_visible
branch
from
4e8abaf
to
3f6ca06
Compare
Thanks for the pull request! I like it overall, I, too, would have appreciated a more customizable approach, to more easily switching from different modes/selection, maybe bevyengine/bevy#7328 is interesting to take inspiration from it. In the meanwhile, this is an acceptable implementation for me. An example and changelog would be great ! |
|
I initially based this PR on how |
Vrixyz
added
enhancement
I needed a way to toggle debug rendering of colliders for group of entities in my project, so I thought of implementing it kind of like bevy
Wireframeworks, with global flag in resource, and if it's off, then per entity with marker component. I also considered just usingVisibilityfor collider entities, but that's seems unintuitive.Oh, I also fixed(fixed in recent master)RapierDebugRenderPlugin::enablednot being used, I'm not sure if creating context withenabled: truewas intentional or just a typo.