Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alternate OID 1.3.14.3.2.29 for sha1 with RSA #940

Merged
merged 4 commits into from Jan 7, 2022
Merged

Added alternate OID 1.3.14.3.2.29 for sha1 with RSA #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0408eb
Added alternate OID 1.3.14.3.2.29 for sha1 with RSA
dpwatrous Oct 21, 2020
cbf53ba
Add helper to create signature digest.
davidlehn Jan 7, 2022
2f38758
Add verification helper.
davidlehn Jan 7, 2022
aaefafa
Fix typos.
davidlehn Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -5,6 +5,17 @@ Forge ChangeLog
- [x509] 'Expected' and 'Actual' issuers were backwards in verification failure
message.

### Added
- [oid,x509]: Added OID `1.3.14.3.2.29 / sha1WithRSASignature` for sha1 with
RSA. Considered a deprecated equivalent to `1.2.840.113549.1.1.5 /
sha1WithRSAEncryption`. See [discussion and
links](https://github.com/digitalbazaar/forge/issues/825).

### Changed
- [x509]: Reduce duplicate code. Add helper function to create a signature
digest given an signature algorithm OID. Add helper function to verify
signatures.

## 1.1.0 - 2022-01-06

### Fixed
Expand Down
2 changes: 2 additions & 0 deletions lib/oids.js
View file
Open in desktop
Expand Up @@ -42,6 +42,8 @@ _IN('1.2.840.10040.4.3', 'dsa-with-sha1');
_IN('1.3.14.3.2.7', 'desCBC');

_IN('1.3.14.3.2.26', 'sha1');
// Deprecated equivalent of sha1WithRSAEncryption
_IN('1.3.14.3.2.29', 'sha1WithRSASignature');
_IN('2.16.840.1.101.3.4.2.1', 'sha256');
_IN('2.16.840.1.101.3.4.2.2', 'sha384');
_IN('2.16.840.1.101.3.4.2.3', 'sha512');
Expand Down