Added alternate OID 1.3.14.3.2.29 for sha1 with RSA #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
==========================================
+ Coverage 79.54% 80.07% +0.52%
==========================================
Files 40 40
Lines 9475 9395 -80
==========================================
- Hits 7537 7523 -14
+ Misses 1938 1872 -66
Continue to review full report at Codecov.
|
davidlehn
force-pushed
the
dpwatrous-dpwatrous/sha1rsa-alias
branch
from
3ed3f97
to
e82b410
Compare
dlongley
approved these changes
Jan 7, 2022
- Reduce duplicate code. - Fix style nit. - Update changelog.
- Reduce duplicate code. - Small cleanups. - Add note about deprecated OID alias.
davidlehn
force-pushed
the
dpwatrous-dpwatrous/sha1rsa-alias
branch
from
e82b410
to
aaefafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to:
Cleans up repeated code.