Update num-bigint to v0.4.2 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compilation is broken on nightly, due to: rust-lang/rust#88581 This commit upgrades the num-bigint package to v0.4.2 which resolves this issue: rust-num/num-bigint#219
chenyan-dfinity
approved these changes
Sep 7, 2021
ninegua
pushed a commit
to ninegua/candid
that referenced
this pull request
Apr 22, 2022
* docs: simplify the sample-javascript Remove authClient and move everything into 3 functions; login, logout and handleCallback. The goal is to move the login and handleCallback in the authentication package and be the low level API. Even lower than that, login will most likely be createRequestUrl() or something to that effect, and leave the navigation to the application layer. * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The compilation is broken on nightly, due to:
rust-lang/rust#88581
This commit upgrades the num-bigint package to v0.4.2 which resolves this issue:
rust-num/num-bigint#219
Requirements
A new minor version of candid should be released with the dependency upgrade and used across the different crates including the ic_cdk.
Considered Solutions
Updating the dependency
Recommended Solution
Considerations
No breaking change is introduced.