Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken on nightly #136

Closed
qti3e opened this issue Sep 7, 2021 · 3 comments
Closed

Build is broken on nightly #136

qti3e opened this issue Sep 7, 2021 · 3 comments

Comments

@qti3e
Copy link

qti3e commented Sep 7, 2021

Since the new Rust nightly release, the v0.4.0 of the num_bigint package is broken which candid is depended on, and since this crate is also depended on the Candid crate, this also fails to build on nightly.

I have already open a PR on the Candid repository to migrate to v0.4.2 of the num_bigint to fix the build errors, until then ic_cdk remains broken too.

Related links:
dfinity/candid#274
rust-lang/rust#88581
rust-num/num-bigint#219

@chenyan-dfinity
Copy link
Contributor

I don't think it blocks the build. This is a minor version bump. You can run cargo update && cargo build or just delete Cargo.lock, it will work fine.

@qti3e
Copy link
Author

qti3e commented Sep 8, 2021

Example build failure on docs.rs, caused due to this version bump:
https://docs.rs/crate/ic-kit/0.4.0/builds/432653

I managed to fix the build on local machine by putting this on my Cargo.toml:

[patch.crates-io]
num-bigint = { git = "https://github.com/rust-num/num-bigint" }

@adamspofford-dfinity
Copy link
Contributor

No longer an issue as of latest nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants