fix: deb and rpm should install master and agent bins into /usr/bin
#5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
|
Yes, please. |
rb-determined-ai
approved these changes
Jan 27, 2023
docs/release-notes/usr-bin.rst
Outdated
Comment on lines
5
to
6
| - Installation: ``.deb`` and ``.rpm`` Linux packages will now install master and agent binaries | ||
| into ``/usr/bin/`` instead of ``usr/local/bin/``. |
There was a problem hiding this comment.
nit: I would offer an explanation why they changed, like "to be more in-line with Unix standards" or "with Debian and RedHat packaging standards" or something. Or even just throw the phrase "more standard" in there somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've always been installing binaries into
/usr/local/bin, but that's wrong. Recent goreleaser update made it obvious #5816.Test Plan
Linux package installs and upgrades from older versions still work okay.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket