Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a priority field for DetektProvider #4923

Merged
merged 1 commit into from Jun 8, 2022
Merged

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Jun 5, 2022

This makes it easier for tools (e.g. IntelliJ plugin) to choose their provider implemention (e.g. in tests).

One usecase can be found here:

https://github.com/detekt/detekt-intellij-plugin/pull/177/files#diff-3c40938670e13746dcbdadc52f2b01f6fbfbefd6153bd152bf0e69d4c233fd0fR122

…e their provider implemention in tests for example
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #4923 (9e863ff) into main (9146e4d) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main    #4923      +/-   ##
============================================
- Coverage     84.83%   84.83%   -0.01%     
  Complexity     3512     3512              
============================================
  Files           497      497              
  Lines         11549    11552       +3     
  Branches       2139     2140       +1     
============================================
+ Hits           9798     9800       +2     
  Misses          686      686              
- Partials       1065     1066       +1     
Impacted Files Coverage Δ
...lin/io/github/detekt/tooling/api/DetektProvider.kt 83.33% <75.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9146e4d...9e863ff. Read the comment docs.

@BraisGabin
Copy link
Member

It is good to see you around :p

@BraisGabin BraisGabin merged commit 7c485f5 into main Jun 8, 2022
@BraisGabin BraisGabin deleted the priority-for-provider branch June 8, 2022 22:34
@BraisGabin BraisGabin added this to the 1.21.0 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants