Make plugin testable by stubbing the detekt instance avoiding compiler classpath errors #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
force-pushed
the
make-plugin-testable
branch
from
b80ac88
to
d2abd3e
Compare
arturbosch
commented
Jun 5, 2022
| @@ -22,7 +22,7 @@ class DetektAnnotator : ExternalAnnotator<PsiFile, List<Finding>>() { | |||
| if (!collectedInfo.project.isDetektEnabled()) { | |||
| return emptyList() | |||
| } | |||
| if (collectedInfo.isKotlinFile()) { | |||
There was a problem hiding this comment.
This line was wrong. It would have skipped every Kotlin file but did not because apparently psiFile.language != KotlinLanguage.INSTANCE,
Fixing the tests made this mistake obvious.
Testing for KtFile does not work either as IntelliJ may use some kind of LightPsiElement structures.
We have to compare language id's here. Kotlin light elements also use KotlinLanguage.INSTANCE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs detekt/detekt#4923 to remove the DetektStub hack at runtime.