set an upper bound on our supported Node for now #7399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
added
tech-debt
|
Here's what the user will see:
|
outofambit
reviewed
Apr 25, 2019
Co-Authored-By: shiftkey <brendan@github.com>
outofambit
approved these changes
Apr 25, 2019
outofambit
added
the
infrastructure
|
Merging this in early because it's such a small change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Node 12 is out, but our version of
node-sassis not compatible with it, which impacts building the project.Description
Until sass/node-sass#2633 lands and a new release is available that we can upgrade the project to, this change will prevent the user from building the project.
This will prevent bug reports where the tooling is not in a supported state, but also give us an indicator of how many contributors are already on Node 12.
Release notes
Notes: no-notes