Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade node-sass so we don't need to block Node 12 usage #7498

Closed
shiftkey opened this issue May 9, 2019 · 0 comments · Fixed by #7670
Closed

upgrade node-sass so we don't need to block Node 12 usage #7498

shiftkey opened this issue May 9, 2019 · 0 comments · Fixed by #7670
Labels
infrastructure Issues and pull requests related to scripts and tooling for GitHub Desktop tech-debt Issues and pull requests related to addressing technical debt or improving the codebase

Comments

@shiftkey
Copy link
Member

shiftkey commented May 9, 2019

node-sass had an update to v4.12.0 recently which enables it to be used within Node 12: https://www.npmjs.com/package/node-sass/v/4.12.0

We use it here in Desktop to convert out SCSS files into CSS as part of the app bundle using sass-loader:

desktop/package.json

Line 94 in 6974d66

"node-sass": "^4.11.0",

If we can verify the app builds and styles aren't affected by the version update, we can then kill off the workaround in #7399.
@shiftkey shiftkey added tech-debt Issues and pull requests related to addressing technical debt or improving the codebase infrastructure Issues and pull requests related to scripts and tooling for GitHub Desktop labels May 9, 2019
This was referenced May 30, 2019
Merged
Closed
@say25 say25 mentioned this issue Jun 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Issues and pull requests related to scripts and tooling for GitHub Desktop tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade node-sass to 4.12.0 say25/desktop
1 participant
@shiftkey