Store exceptions to be reported later #9601
Open
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nishnha
force-pushed
the
jurre/async-capture-core-errors
branch
from
ad42509
to
aff6df5
Compare
Nishnha
force-pushed
the
jurre/async-capture-core-errors
branch
from
d3da0b1
to
9aee49d
Compare
Nishnha
changed the title
jakecoffman
reviewed
Apr 24, 2024
| Dependabot::ExceptionCapturer.handle_captured_exceptions do |exception| | ||
| service.capture_exception(error: exception, tags: tags) | ||
| end | ||
| service.capture_exception(error: error, tags: tags) |
There was a problem hiding this comment.
I think we want to put this down below 👇 We're eating the exception in the MessageBuilder so it won't reach this code in the trap.
What might be simpler would be give the ExceptionCapturer the service here (outside of the trap), and have it log to the API immediately when capture_exception is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store exceptions to be reported later. This is useful for things like the message builder which runs in a separate process from the rest of the PR creation.