Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report suppressed MessageBuilder exceptions to the service #9564

Open
jakecoffman opened this issue Apr 22, 2024 · 2 comments
Open

report suppressed MessageBuilder exceptions to the service #9564

jakecoffman opened this issue Apr 22, 2024 · 2 comments

Comments

@jakecoffman
Copy link
Member

Code improvement description

In #9560 I started printing the suppressed exception, however it would be best to also report it to Sentry so we can see when we introduce regressions.

Due to the architecture of command and updater, this is a bit tricky.

One way that just occurred to me is to store those exceptions in an array of errors on the MessageBuilder, and have the updater check that array for entries and report them to Sentry after the MessageBuilder runs.

@jurre
Copy link
Member

jurre commented Apr 24, 2024

@jakecoffman I think something like this could do the trick? It's a bit more generic than storing it on the MessageBuilder and this way we can reuse it across all of core where we might run into a similar situation where we don't want to raise on errors, but we do want to report them to Sentry

#9601

@Nishnha
Copy link
Member

Nishnha commented Apr 24, 2024

I updated #9601 and it's passing CI now. How would we go about testing + releasing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Scoping
Development

No branches or pull requests

4 participants