-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): Improve Error Handling and-Dot Handling in-fqdn! Macro #23590
Open
yazan-nidal
wants to merge
36
commits into
denoland:main
Choose a base branch
from
yazan-nidal:fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-in-fqdn!-Macro
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
91b438e
Implement improvements for error handling and dot handling in fqdn! m…
yazan-nidal 01b8f01
add tests for modified fqdn
yazan-nidal cc8a798
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 3aa5ca0
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal ea3cc59
Implement improvements(v2) for error handling and dot handling in fqd…
yazan-nidal 2fbaf97
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal f8bfa41
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 589d407
add failed parse domain tests
yazan-nidal 9e373ce
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 1bbf516
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 114cc7a
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
bartlomieju 694aa25
fmt
bartlomieju 92a9509
Fix lint issues
yazan-nidal d7a541d
fmt
yazan-nidal c74d45f
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 1bbc4f6
Merge branch 'denoland:main' into fix-(runtime)-Improve-Error-Handlin…
yazan-nidal 166d117
fix: improve parsing of IPv6, IPv4, hostnames, and URLs; make port op…
yazan-nidal 6f8664b
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 40fe3bb
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
dsherret 816b410
Merge branch 'fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-i…
yazan-nidal dd15f60
enhancing
yazan-nidal 2179fe8
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 49c4053
update Cargo.lock
bartlomieju e7a41b0
fmt
bartlomieju b4b84ab
fmt#
yazan-nidal 5c63b47
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal d704574
fmt#
yazan-nidal 3008de6
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 233111f
Merge branch 'fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-i…
yazan-nidal 8b8e240
fmt
yazan-nidal 58efbb5
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
yazan-nidal 932efa7
fmt#
yazan-nidal 68c6104
Merge branch 'fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-i…
yazan-nidal 280035e
Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…
dsherret 05c6689
lint
yazan-nidal 390b79c
Merge remote-tracking branch 'origin/fix-(runtime)-Improve-Error-Hand…
yazan-nidal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
tests/specs/run/net_descriptor_invalid_with_special_characters/__test__.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"tempDir": true, | ||
"steps": [ | ||
{ | ||
"args": " run --allow-read --allow-env --allow-write=notion-next --allow-net=api.notion.com,www.google.com,*.amazon.com main.js", | ||
"output": "err_i.out", | ||
"exitCode": 1 | ||
}, | ||
{ | ||
"args": " run --allow-net main.js", | ||
"output": "err_ii.out", | ||
"exitCode": 1 | ||
} | ||
] | ||
} |
4 changes: 4 additions & 0 deletions
4
tests/specs/run/net_descriptor_invalid_with_special_characters/err_i.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
error: Failed to parse *.amazon.com | ||
|
||
Caused by: | ||
invalid char found in FQDN |
2 changes: 2 additions & 0 deletions
2
tests/specs/run/net_descriptor_invalid_with_special_characters/err_ii.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
error: Uncaught (in promise) Error: No such host is known. (os error 11001) | ||
at async Object.connect (ext:deno_net/01_net.js:587:55) |
2 changes: 2 additions & 0 deletions
2
tests/specs/run/net_descriptor_invalid_with_special_characters/main.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Deno.connect({ hostname: "api.notion.com.", port: 443 }); | ||
Deno.connect({ hostname: "*.amazon.com.", port: 443 }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.