Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): Improve Error Handling and-Dot Handling in-fqdn! Macro (closed) #23590

Commits on Apr 28, 2024

  1. Implement improvements for error handling and dot handling in fqdn! m…

    …acro
    
    This commit addresses issue denoland#23294 by enhancing the error handling and dot handling logic within the fqdn! macro. Specifically, it:
    - Handles parsing errors gracefully using pattern matching instead of unwrap().
    - Adjusts substring parsing to correctly handle domain names ending with a dot.
    
    This change improves the reliability and robustness of the fqdn! macro, ensuring more accurate parsing of fully qualified domain names.
    
    Fixes: denoland#23294
    yazan-nidal committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    91b438e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    01b8f01 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cc8a798 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3aa5ca0 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Implement improvements(v2) for error handling and dot handling in fqd…

    …n! macro
    
    This commit addresses issue (denoland#23294 , denoland#23552) by enhancing the error handling and dot handling logic within the fqdn! macro. Specifically, it:
    
    Handles parsing errors gracefully using pattern matching instead of unwrap().
    Adjusts substring parsing to correctly handle domain names ending with a dot.
    This change improves the reliability and robustness of the fqdn! macro, ensuring more accurate parsing of fully qualified domain names.
    
    Fixes: denoland#23294 , denoland#23552
    yazan-nidal committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ea3cc59 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2fbaf97 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f8bfa41 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    589d407 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9e373ce View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1bbf516 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    bartlomieju committed May 9, 2024
    Configuration menu
    Copy the full SHA
    114cc7a View commit details
    Browse the repository at this point in the history
  2. fmt

    bartlomieju committed May 9, 2024
    Configuration menu
    Copy the full SHA
    694aa25 View commit details
    Browse the repository at this point in the history
  3. Fix lint issues

    yazan-nidal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    92a9509 View commit details
    Browse the repository at this point in the history
  4. fmt

    yazan-nidal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d7a541d View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 12, 2024
    Configuration menu
    Copy the full SHA
    c74d45f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'denoland:main' into fix-(runtime)-Improve-Error-Handlin…

    …g-and-Dot-Handling-in-fqdn!-Macro
    yazan-nidal committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1bbc4f6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. fix: improve parsing of IPv6, IPv4, hostnames, and URLs; make port op…

    …tional; enable net access for host on specified port
    
    - Enhanced parsing logic for IPv6 and IPv4 addresses, as well as hostnames and URLs
    - Made port extraction optional by supporting the ":port" syntax in hostnames
    - Ensured consistent modification of `IpAddr` struct without cloning
    - Added error handling for invalid IPv6 format and missing port specifications
    - Enabled network access for the specified host on the given port
    - Refactored helper functions for better readability and maintainability
    yazan-nidal committed May 23, 2024
    Configuration menu
    Copy the full SHA
    166d117 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    
    # Conflicts:
    #	Cargo.lock
    #	ext/net/Cargo.toml
    yazan-nidal committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6f8664b View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    dsherret committed May 23, 2024
    Configuration menu
    Copy the full SHA
    40fe3bb View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-i…

    …n-fqdn!-Macro' of https://github.com/yazan-nidal/deno into fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-in-fqdn!-Macro
    yazan-nidal committed May 27, 2024
    Configuration menu
    Copy the full SHA
    816b410 View commit details
    Browse the repository at this point in the history
  2. enhancing

    yazan-nidal committed May 27, 2024
    Configuration menu
    Copy the full SHA
    dd15f60 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2179fe8 View commit details
    Browse the repository at this point in the history
  4. update Cargo.lock

    bartlomieju committed May 27, 2024
    Configuration menu
    Copy the full SHA
    49c4053 View commit details
    Browse the repository at this point in the history
  5. fmt

    bartlomieju committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e7a41b0 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. fmt#

    yazan-nidal committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b4b84ab View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5c63b47 View commit details
    Browse the repository at this point in the history
  3. fmt#

    yazan-nidal committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d704574 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3008de6 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-i…

    …n-fqdn!-Macro' of https://github.com/yazan-nidal/deno into fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-in-fqdn!-Macro
    yazan-nidal committed May 28, 2024
    Configuration menu
    Copy the full SHA
    233111f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. fmt

    yazan-nidal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8b8e240 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    yazan-nidal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    58efbb5 View commit details
    Browse the repository at this point in the history
  3. fmt#

    yazan-nidal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    932efa7 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-i…

    …n-fqdn!-Macro' of https://github.com/yazan-nidal/deno into fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-in-fqdn!-Macro
    yazan-nidal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    68c6104 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'main' into fix-(runtime)-Improve-Error-Handling-and-Dot…

    …-Handling-in-fqdn!-Macro
    dsherret committed May 30, 2024
    Configuration menu
    Copy the full SHA
    280035e View commit details
    Browse the repository at this point in the history
  2. lint

    yazan-nidal committed May 30, 2024
    Configuration menu
    Copy the full SHA
    05c6689 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/fix-(runtime)-Improve-Error-Hand…

    …ling-and-Dot-Handling-in-fqdn!-Macro' into fix-(runtime)-Improve-Error-Handling-and-Dot-Handling-in-fqdn!-Macro
    yazan-nidal committed May 30, 2024
    Configuration menu
    Copy the full SHA
    390b79c View commit details
    Browse the repository at this point in the history