Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repl): don't panic on lone surrogates #12899

Closed
wants to merge 6 commits into from
Closed

fix(repl): don't panic on lone surrogates #12899

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a894cb
fix(repl): don't panic on lone surrogates
lucacasonato Nov 25, 2021
4c8115f
Merge branch 'main' into fix_utf8_repl
dsherret Nov 25, 2021
79e4ddc
Format
dsherret Nov 25, 2021
c9df219
Fix issues.
dsherret Nov 25, 2021
6e2eed9
fix
lucacasonato Nov 25, 2021
d29ab00
Merge branch 'main' into fix_utf8_repl
bartlomieju Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Cargo.toml
View file
Open in desktop
Expand Up @@ -27,6 +27,10 @@ members = [
]
exclude = ["test_util/std/hash/_wasm"]

# use serde_json lucacasonato/json.git@5ec8141acf127d9dcbc01b2b63c6426d158ee1af
[patch.crates-io]
serde_json = { git = "https://github.com/lucacasonato/json.git", rev = "5ec8141acf127d9dcbc01b2b63c6426d158ee1af" }

lucacasonato marked this conversation as resolved.
Show resolved Hide resolved
# NB: the `bench` and `release` profiles must remain EXACTLY the same.
[profile.release]
codegen-units = 1
Expand Down
29 changes: 20 additions & 9 deletions cli/tools/coverage.rs
View file
Open in desktop
Expand Up @@ -84,25 +84,37 @@ impl CoverageCollector {
}

async fn enable_debugger(&mut self) -> Result<(), AnyError> {
self.session.post_message("Debugger.enable", None).await?;
self
.session
.post_message("Debugger.enable", None::<()>)
.await?;

Ok(())
}

async fn enable_profiler(&mut self) -> Result<(), AnyError> {
self.session.post_message("Profiler.enable", None).await?;
self
.session
.post_message("Profiler.enable", None::<()>)
.await?;

Ok(())
}

async fn disable_debugger(&mut self) -> Result<(), AnyError> {
self.session.post_message("Debugger.disable", None).await?;
self
.session
.post_message("Debugger.disable", None::<()>)
.await?;

Ok(())
}

async fn disable_profiler(&mut self) -> Result<(), AnyError> {
self.session.post_message("Profiler.disable", None).await?;
self
.session
.post_message("Profiler.disable", None::<()>)
.await?;

Ok(())
}
Expand All @@ -111,13 +123,12 @@ impl CoverageCollector {
&mut self,
parameters: StartPreciseCoverageParameters,
) -> Result<StartPreciseCoverageReturnObject, AnyError> {
let parameters_value = serde_json::to_value(parameters)?;
let return_value = self
.session
.post_message("Profiler.startPreciseCoverage", Some(parameters_value))
.post_message("Profiler.startPreciseCoverage", Some(parameters))
.await?;

let return_object = serde_json::from_value(return_value)?;
let return_object = serde_json::from_str(return_value.get())?;

Ok(return_object)
}
Expand All @@ -127,10 +138,10 @@ impl CoverageCollector {
) -> Result<TakePreciseCoverageReturnObject, AnyError> {
let return_value = self
.session
.post_message("Profiler.takePreciseCoverage", None)
.post_message("Profiler.takePreciseCoverage", None::<()>)
.await?;

let return_object = serde_json::from_value(return_value)?;
let return_object = serde_json::from_str(return_value.get())?;

Ok(return_object)
}
Expand Down