fix(repl): don't panic on lone surrogates #12899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the pancis that occur when a user does various actions using strings containing lone surrogates in the REPL. It does this by introducing a new `LossyString` type that implements `serde::Deserialize`. This deserializer supprots deserializing JSON strings that contain lone surrogates. It replaces lone surrogates with the unicode replacement character.
lucacasonato
commented
Nov 25, 2021
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
lucacasonato
requested review from
bartlomieju,
bnoordhuis and
dsherret
as code owners
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the pancis that occur when a user does various actions
using strings containing lone surrogates in the REPL. It does this by
introducing a new
LossyStringtype that implementsserde::Deserialize. This deserializer supprots deserializing JSONstrings that contain lone surrogates. It replaces lone surrogates with
the unicode replacement character.
Fixes #12226 and #12447.
Waiting on merge and release of serde-rs/json#830.