Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to rustls 0.20 #12488

Merged
merged 23 commits into from Dec 6, 2021
Merged

chore: upgrade to rustls 0.20 #12488

merged 23 commits into from Dec 6, 2021

Conversation

ry
Copy link
Member

@ry ry commented Oct 19, 2021

@ry ry changed the title port test_util to rustls 0.20 upgrade to rustls 0.20 Oct 19, 2021
@piscisaureus
Copy link
Member

  • I would like to land feat(ext/net): add TlsConn.handshake() #12467 before attempting to upgrade ext/net to use rustls 0.20
  • Our websocket implementation uses tokio-tungstenite, but it can also use our own TlsStream from ext/net. So no need to make an effort to port over tokio-tungstenite.

@satyarohith
Copy link
Member

All the dependencies are now upgraded to rustls 0.20.

@realtimetodie
Copy link
Contributor

Please update reqwest as well, as they switched to rustls 0.20.x in 0.11.7.

@bartlomieju bartlomieju changed the title upgrade to rustls 0.20 chore: upgrade to rustls 0.20 Dec 1, 2021
@piscisaureus
Copy link
Member

@bartlomieju
I fixed the TlsStreamInner::poll_io() state machine so most tests pass now.
I believe the remaining issue is related to ALPN support.

@bartlomieju
Copy link
Member

@bartlomieju I fixed the TlsStreamInner::poll_io() state machine so most tests pass now. I believe the remaining issue is related to ALPN support.

Thank you, I will fix the rest.

@piscisaureus
Copy link
Member

@bartlomieju
It is green now but I think the PR still needs a final cleanup.
There's still this duplicated code, a todo!() comment, probably more.

@bartlomieju
Copy link
Member

@bartlomieju It is green now but I think the PR still needs a final cleanup. There's still this duplicated code, a todo!() comment, probably more.

Sure, I'll handle that tomorrow.

@bartlomieju
Copy link
Member

@piscisaureus I addressed todo!() and removed some duplication of code (not all, but I left relevant comments as to why that is happening). Please review.

cli/proc_state.rs Outdated Show resolved Hide resolved
cli/standalone.rs Outdated Show resolved Hide resolved
test_util/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits.

@bartlomieju bartlomieju merged commit a2f1357 into main Dec 6, 2021
@piscisaureus piscisaureus deleted the rustls20 branch December 6, 2021 23:56
andreubotella pushed a commit to andreubotella/deno that referenced this pull request Dec 16, 2021
andreubotella pushed a commit to andreubotella/deno that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants