test(http): fix error message of unknown issuer #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyarohith
approved these changes
Dec 7, 2021
satyarohith
reviewed
Dec 7, 2021
| @@ -553,7 +553,7 @@ Deno.test({ | |||
| await assertThrowsAsync( | |||
| () => badConn.read(new Uint8Array(1)), | |||
| Deno.errors.InvalidData, | |||
| "invalid certificate: UnknownIssuer", | |||
| "invalid peer certificate contents: invalid peer certificate: UnknownIssuer", | |||
There was a problem hiding this comment.
We should fix the error message to be less verbose in Deno. The old one seems to be on point.
There was a problem hiding this comment.
It will be hard as this error is surfaced from rustls and we'd have to manually rewrite it. I think it's not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error message expectations in https server tests. This should fix the CI failure in main
(The error is first observed in main 1 hour ago. It's probably caused by denoland/deno#12488)