Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems #917

Merged
merged 6 commits into from Feb 24, 2021
Merged

Update gems #917

merged 6 commits into from Feb 24, 2021

Conversation

miharekar
Copy link
Contributor

@miharekar miharekar commented Feb 22, 2021

Description

Split into several commits. The first 2 are simple but ideally we'd merge all:

  1. updated dev/test gems
  2. updated rails gems
  3. the rest of the gems:
  4. Fixes for changes in DatabaseCleaner API
  5. GraphQL::Pagination::Connections is now the default, removed use GraphQL::Pagination::Connections
  6. Fix pry-byebug

I've tested the oauth flows and puma forking. Could you do some extra testing as well? On the staging app perhaps?

@miharekar miharekar temporarily deployed to advisable-pi-update-gem-ebyfae February 22, 2021 09:55 Inactive
@miharekar miharekar temporarily deployed to advisable-pi-update-gem-ebyfae February 22, 2021 14:14 Inactive
@miharekar miharekar temporarily deployed to advisable-pi-update-gem-ebyfae February 22, 2021 15:13 Inactive
thomascullen
thomascullen previously approved these changes Feb 22, 2021
Copy link
Collaborator

@thomascullen thomascullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working for me. Only thing I noticed is that running rails c outputs

/Users/thomascullen/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/pry-byebug-3.8.0/lib/pry-byebug/control_d_handler.rb:5: warning: control_d_handler's arity of 2 parameters was deprecated (eval_string, pry_instance). Now it gets passed just 1 parameter (pry_instance)

Although the console still loads.

@miharekar
Copy link
Contributor Author

@thomascullen I saw that as well but assumed it wasn't fixed in pry-byebug yet. But after investigating it seems that pry-byebug is currently not compatible with the latest pry so they added that in dependencies. But, there is an older version, that does not have that dependency version limitation so bundle update went to that one.

I pushed another commit, and here's the issue about incompatibility: deivid-rodriguez/pry-byebug#343

@miharekar miharekar temporarily deployed to advisable-pi-update-gem-ebyfae February 24, 2021 07:19 Inactive
@thomascullen
Copy link
Collaborator

@miharekar Ah nice, should be good to go then!

@miharekar miharekar merged commit 1a71a41 into master Feb 24, 2021
@miharekar miharekar deleted the update-gems branch February 24, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants