Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby-head CI suite #1387

Merged
merged 1 commit into from Jan 7, 2022

Conversation

ashishkeshan
Copy link
Contributor

The ruby-head test suite is currently failing due to:

Failure/Error: require 'pry-byebug'

NameError:
  undefined method `=~' for class `Pry::Code'

which was actually fixed in pry version 0.14.0, but unfortunately, pry-byebug’s latest version only allows for pry version 0.13.0 due to this unresolved issue: deivid-rodriguez/pry-byebug#343

Since pry-byebug is only used locally and not in production systems, I think it's okay to remove it in versions of ruby >= 3.2 (which introduce the issue) to unblock the CI suites for now until pry-byebug begins supporting later versions of pry that incorporate the fix.

Copy link

@Bestra Bestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable short-term fix. This would need to be addressed for any future work we do, and I like seeing a separate PR for it. 👍 from me, now we'll need another review from the octokit team.

@indigok indigok merged commit c03e168 into octokit:4-stable Jan 7, 2022
@ashishkeshan ashishkeshan deleted the fix-ruby-head-CI-suite branch January 7, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants