Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 11.1.2 regression #674

Merged
merged 1 commit into from Apr 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/windows.yml
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
version: [2.4.9, 2.5.7, 2.6.5, head]
version: [2.4.9, 2.5.7, 2.6.5, 2.7.0, head]

steps:
- uses: actions/checkout@v2
Expand All @@ -33,8 +33,7 @@ jobs:
run: |
git clone -q --depth=5 --no-tags --branch=byebug https://github.com/deivid-rodriguez/rb-readline.git C:\rb-readline
$n_dir = $(ruby -e "print RbConfig::CONFIG['sitelibdir']")
Copy-Item -Path C:\rb-readline\lib\readline.rb -Destination $n_dir\readline.rb
Copy-Item -Path C:\rb-readline\lib\rbreadline.rb -Destination $n_dir\rbreadline.rb
Copy-Item -Path C:\rb-readline\lib\* -Destination $n_dir -Recurse

- name: Setup dependencies
shell: bash
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Fixed

* [#674](https://github.com/deivid-rodriguez/byebug/pull/674): crash when using byebug on ruby 2.7.0 on Windows.

## [11.1.2] - 2020-04-17

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion lib/byebug/interfaces/local_interface.rb
Expand Up @@ -53,7 +53,7 @@ def without_readline_completion
return yield unless orig_completion

begin
Readline.completion_proc = nil
Readline.completion_proc = ->(_) { nil }
yield
ensure
Readline.completion_proc = orig_completion
Expand Down