Fix 11.1.2 regression #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default ruby 2.7.0 on Windows comes with rb-readline, which doesn't like `nil` completion procs, and with a version of `irb` that installs its own completion proc. That combination causes `byebug` to crash. Installing a dummy "nil proc" seems like the most compatible thing to do.
deivid-rodriguez
force-pushed
the
fix_regression
branch
from
4e02619
to
721b5a9
Compare
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 27, 2020
Update ruby-byebug to 11.1.3. ## [11.1.3] - 2020-04-23 ### Fixed * [#674](deivid-rodriguez/byebug#674): crash when using byebug on ruby 2.7.0 on Windows. ## [11.1.2] - 2020-04-17 ### Fixed * [#657](deivid-rodriguez/byebug#657): crash when hitting \<TAB\> due to IRB completion mechanism included in the default ruby 2.7 version of the `irb` gem ([@terceiro]).
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673.