Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade torch and let transformers pick the version #3727

Merged
merged 2 commits into from Dec 16, 2022

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Dec 16, 2022

Related Issues

Proposed Changes:

  • PyTorch 1.13.1 was released today and CI test passed. Version 1.13.0 and 1.13.1 both work now with Haystack so it is save to upgrade. Let's upgrade! We will use the same version range as transformers so we let transformers install torch as one of it's dependencies.

How did you test it?

CI and so manual tests

Notes for the reviewer

Checklist

@julian-risch julian-risch requested a review from a team as a code owner December 16, 2022 10:20
@julian-risch julian-risch requested review from masci and removed request for a team and masci December 16, 2022 10:20
@vblagoje
Copy link
Member

@julian-risch This is great! So we can set the torch to "torch>=1.7,!=1.12.0" and move on?

@julian-risch
Copy link
Member Author

I think we need to exclude 1.13.0 too. Let's double check and have a quick chat.

@julian-risch
Copy link
Member Author

To sum up the discussion: we let transformers handle the pytorch version, which results in "torch>=1.7,!=1.12.0", as of now: https://github.com/huggingface/transformers/blob/main/setup.py#L169

@julian-risch julian-risch changed the title test torch 1.13.1 release chore: upgrade torch and let transformers pick the version Dec 16, 2022
@julian-risch julian-risch changed the title chore: upgrade torch and let transformers pick the version build: upgrade torch and let transformers pick the version Dec 16, 2022
@vblagoje
Copy link
Member

@mayankjobanputra can you approve this one, if all is good?

@mayankjobanputra
Copy link
Collaborator

I also checked the logs... Looks super perfect!

Requirement already satisfied: torch>=1.3.0 in /opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages (from espnet==202209->farm-haystack==1.13.0rc0) (1.13.1)

@mayankjobanputra mayankjobanputra merged commit adde194 into main Dec 16, 2022
@mayankjobanputra mayankjobanputra deleted the torch-1131 branch December 16, 2022 16:03
bogdankostic pushed a commit that referenced this pull request Dec 22, 2022
* test torch 1.13.1 release

* let transformers handle torch version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade torch to 1.13.0
3 participants