Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate names with initialisms #749

Merged

Conversation

wtertius
Copy link
Contributor

Adding support of two naming styles:

  • new - with initialisms like MyHTTPHandlerForAPI
  • old - with simple camel case like MyHttpHandlerForApi

By the steps of #715.

@wtertius wtertius force-pushed the generate_names_with_initialisms branch from 664f246 to 74d13ef Compare September 12, 2022 09:16
@deepmap-marcinr
Copy link
Contributor

While it's nice to be consistent with initialisms, I generally feel it's not worth changing the code generation behavior for things like this, because lots of people will need to update their code once it breaks, or we need to flagify this fix to be optional.

@Jleagle
Copy link
Contributor

Jleagle commented Oct 13, 2022

Does it not default to the current behaviour, and only a config change will break things, which is expected?

@deepmap-marcinr deepmap-marcinr merged commit 56f7bee into deepmap:master Oct 22, 2022
@deepmap-marcinr
Copy link
Contributor

Sorry, looked too fast. I resolved a bunch of conflicts (hopefully correctly). Thanks for the fix.

@deepmap-marcinr
Copy link
Contributor

Sorry, I had to revert, because some initialisms broke in the existing code, and I had compiler errors. I'm happy to merge this, once it doesn't break existing code (or maybe I merged conflicts improperly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants