Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to tweak generated names (including use of initialisms) #1041

Merged
merged 27 commits into from May 4, 2024
Merged

feat: add ability to tweak generated names (including use of initialisms) #1041

merged 27 commits into from May 4, 2024

Conversation

wtertius
Copy link
Contributor

@wtertius wtertius commented May 5, 2023

Adding support of three naming styles:

  • new - with initialisms like MyHTTPHandlerForAPI
  • old - with simple camel case like MyHttpHandlerForApi
    By the steps of Generate names with initialisms #749 but without breaking changes.

@wtertius wtertius force-pushed the generate_names_with_initialisms_wo_bc branch from 2e92b52 to 7bfbe37 Compare May 5, 2023 10:41
@wtertius wtertius force-pushed the generate_names_with_initialisms_wo_bc branch from 7bfbe37 to c1467da Compare May 5, 2023 11:06
@derbylock
Copy link

Can we merge this PR? @jamietanna, cant I help somehow to merge this PR?

@jamietanna jamietanna added this to the v1.15.0 milestone Sep 2, 2023
@jamietanna jamietanna modified the milestones: v1.16.0, v2.1.0 Oct 23, 2023
@jamietanna jamietanna modified the milestones: v2.1.0, v2.2.0 Jan 25, 2024
jamietanna
jamietanna reviewed May 4, 2024
View reviewed changes
Copy link
Collaborator

@jamietanna jamietanna left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finishing off updating this, TODO:

  • Create an examples for each of the options, to indicate differences
  • README updates?
  • Find what's closed by this - there are I'm sure a few other issues

@jamietanna jamietanna mentioned this pull request May 4, 2024
Closed
@jamietanna
Copy link
Collaborator

Thanks very much for this @wtertius 💜 This is a great solution - I've made a couple of tweaks to add additional test cases + some new docs (alongside recent project changes) and will merge it shortly

@jamietanna jamietanna merged commit af43038 into deepmap:master May 4, 2024
12 checks passed
@jamietanna jamietanna changed the title Generate names with initialisms wo bc feat: add ability to tweak generated names (including use of initialisms) May 4, 2024
@jamietanna jamietanna added the enhancement New feature or request label May 4, 2024
@wtertius wtertius deleted the generate_names_with_initialisms_wo_bc branch May 6, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wtertius @derbylock @jamietanna