chi : Change the signature of the MiddlewareFunc for compatibilities.
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atibilities with another libraries.
|
Related issue #286 As @deepmap-marcinr said, this PR breaks people's code. There is an easy work-around to fix the template version. |
namco1992
added a commit
to namco1992/oapi-codegen
that referenced
this pull request
Jun 30, 2023
This PR ported the fix deepmap#578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
namco1992
added a commit
to namco1992/oapi-codegen
that referenced
this pull request
Aug 8, 2023
This PR ported the fix deepmap#578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
namco1992
added a commit
to namco1992/oapi-codegen
that referenced
this pull request
Aug 8, 2023
This PR ported the fix deepmap#578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
jamietanna
pushed a commit
that referenced
this pull request
Sep 2, 2023
This PR ported the fix #578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
) This PR ported the fix deepmap#578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…atibilities with another libraries. (deepmap#578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of the
MiddlewareFuncfor chi, and get more compatibility in the ecosystem.Before:
Now:
Almost another famous middleware libraries for
net/httpin Go has a function signature below.For example,