[Gorilla] update the MiddlewareFunc type for compatibility
#1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamietanna @deepmap-marcinr I suppose this change will be ok since the last one #578 doesn't seem to have that much of a repercussion. Thanks! |
|
@namco1992 mind addressing the conflicts? After that - following the case we've already done this in a somewhat-but-not-that-bad breaking change, I'll merge it |
jamietanna
added
awaiting reply
enhancement
namco1992
force-pushed
the
gorilla-middleware-type
branch
from
9268ad0
to
759311e
Compare
This PR ported the fix deepmap#578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
namco1992
force-pushed
the
gorilla-middleware-type
branch
from
759311e
to
6b066d4
Compare
|
@jamietanna Resolved the conflicts, thanks! |
jamietanna
added a commit
that referenced
this pull request
Sep 2, 2023
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
) This PR ported the fix deepmap#578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too. Signed-off-by: Mengnan Gong <namco1992@gmail.com>
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ported the fix #578 to gorilla/mux, so the gorilla/mux users can have a consistent behaviour too.