Update gin example to use most recent release changes #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent release of `oapi-codegen` (v1.10.0) included changes that broke the existing examples which were introduced in deepmap#530 This change updates the `gin` example by regening the code-generated files and updating the router registration to work with the new generated code.
|
Thank you.
…________________________________________
From: Eric Volpert ***@***.***>
Sent: Tuesday, May 3, 2022 10:21 PM
To: deepmap/oapi-codegen
Cc: Marcin Romaszewicz; State change
Subject: Re: [deepmap/oapi-codegen] Update gin example to use most recent release changes (PR #554)
This example was #530<#530> which has since been rolled back, I don't think this should have been merged unless we decide to re-roll out the changes in #530<#530> with a version bump that makes sense since they are breaking.
—
Reply to this email directly, view it on GitHub<#554 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALKC5DE7WKW6XOBRXBAHNVLVIICMXANCNFSM5TZSPKEA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
deepmap-marcinr
pushed a commit
that referenced
this pull request
May 4, 2022
This reverts commit 09c1d86. I merged it after rolling back a change that it was dependent on. #554 (comment)
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
The most recent release of `oapi-codegen` (v1.10.0) included changes that broke the existing examples which were introduced in deepmap#530 This change updates the `gin` example by regening the code-generated files and updating the router registration to work with the new generated code.
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…p#554)" This reverts commit d9f6567. I merged it after rolling back a change that it was dependent on. deepmap#554 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent release of
oapi-codegen(v1.10.0) included changesthat broke the existing examples which were introduced in #530
This change updates the
ginexample by regenerating the code-generated files andupdating the router registration to work with the new generated code.
It's worth considering whether we should update the
gintemplate to return a concretetype instead of the
IRouterinterface.When the
IRouterinterface was introduced it seemed to exist just to allow mocking of theinterface (gin-gonic/gin#1607) so I think it may be reasonable to just return
a
gin.RouterGroupfrom theRegisterHandlersWithOptionsandRegisterHandlersgenerated functions.