Return a struct from gin
's RegisterHandlers instead of an interface
#555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides an alternative to #554 based on the discussions in #530.
For setting up a Gin engine, we want to handle the
IRouter
interface when registering handlers, but as this only thinly wraps a*gin.GroupRouter
, we can return a*gin.GroupRouter
from the registration function.We could refactor the
RegisterHandlers
andRegisterHandlersWithOptions
to just take a*gin.GroupRouter
to begin with, I'm not really sure what we gain by using theIRouter
interface here. Does anyone have opinions on doing that?