Upgrade js-yaml to 3.10.0.
#592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main fix we are wanting is outputting astral characters (emojis) as a single escape instead of surrogate pairs: nodeca/js-yaml#368.
tech4him1
force-pushed
the
upgrade-js-yaml
branch
from
a16fa0c
to
0985468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
The main fix we are wanting is outputting astral characters (emojis) as a single escape instead of surrogate pairs: nodeca/js-yaml#368.
Because of howyarnworks, this doesn't upgrade our front-matter YAML parser, because that is technically apreliminariesdependency. The only bugs fixed injs-yaml@3.10.0were dumping bugs, not parsing ones, so I think we are still fine this way, because we would be using3.9.1for parsing, but the newer version for dumping. Any thoughts, or just wait until we switch togrey-matter?I also went ahead and updated the
preliminariesfront-matter parser too, so that it would use the newer version ofjs-yamlas well.Closes #577.
- Test plan
Manually tested to be working.
- Description for the changelog
Upgrade
js-yamlto 3.10.0.