Switch back to gray-matter for front-matter parsing.
#601
Conversation
tech4him1
force-pushed
the
upgrade-gray-matter
branch
2 times, most recently
from
afd871c
to
be05569
Compare
tech4him1
changed the title
gray-matter for front-matter parsing.gray-matter for front-matter parsing.
tech4him1
changed the title
gray-matter for front-matter parsing.gray-matter for front-matter parsing.
tech4him1
force-pushed
the
upgrade-gray-matter
branch
from
be05569
to
362ec92
Compare
tech4him1
changed the title
gray-matter for front-matter parsing.gray-matter for front-matter parsing.
tech4him1
changed the title
gray-matter for front-matter parsing.gray-matter for front-matter parsing.
tech4him1
changed the title
gray-matter for front-matter parsing.gray-matter for front-matter parsing.
tech4him1
force-pushed
the
upgrade-gray-matter
branch
from
43d31bf
to
ed62497
Compare
| toml: tomlEng.parse.bind(tomlEng), | ||
| json: (input) => { | ||
| let JSONinput = input.trim(); | ||
| // Fix JSON if leading and trailing brackets were trimmed. |
There was a problem hiding this comment.
Why would brackets be trimmed?
There was a problem hiding this comment.
Delimiters always get trimmed. For stuff like YAML where the delims are --- and not actually part of the code that is helpful. But with JSON, the delimiters { and } get trimmed, but they actually need to be in there for the parser. With preliminaries they did this too, here: preliminaries/index.js#L376-L379
We can't just add them all the time, though, we have to if-check first, because they could have wrapped the whole thing in a ---json delimiter, in which case the brackets wouldn't get trimmed.
There was a problem hiding this comment.
You can also see the difference in the tests:
https://github.com/netlify/netlify-cms/blob/3195f30b8d174b4820ef65d07d64ded336477af8/src/formats/__tests__/frontmatter.spec.js#L69
vs
https://github.com/netlify/netlify-cms/blob/3195f30b8d174b4820ef65d07d64ded336477af8/src/formats/__tests__/frontmatter.spec.js#L81
tech4him1
force-pushed
the
upgrade-gray-matter
branch
from
ed62497
to
1ebbc05
Compare
This upgrade allow `gray-matter` to work in browsers as well.
tech4him1
force-pushed
the
upgrade-gray-matter
branch
from
1ebbc05
to
86c4987
Compare
- Summary
Switch from
preliminariesback togray-matterfor front-matter parsing.This is currently based on #592, and will be rebased after that one is merged.done- Test plan
Passes current front-matter tests.
- Description for the changelog
Switch back to
gray-matterfor front-matter parsing.