Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix bool coercion to 0/1 (#4512) #4516

Merged
merged 1 commit into from
Dec 20, 2021
Merged

[Backport] Fix bool coercion to 0/1 (#4512) #4516

merged 1 commit into from
Dec 20, 2021

Conversation

leahwicz
Copy link
Contributor

Description

Backport of #4512

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@jtcohen6 @leahwicz
Fix bool coercion to 0/1 (#4512)
4e87da0 
* Fix bool coercion

* Fix unit test
@cla-bot cla-bot bot added the cla:yes label Dec 19, 2021
@leahwicz leahwicz changed the title Fix bool coercion to 0/1 (#4512) [Backport] Fix bool coercion to 0/1 (#4512) Dec 19, 2021
@gshank gshank self-requested a review December 20, 2021 14:05
@leahwicz leahwicz merged commit 29fa687 into 1.0.latest Dec 20, 2021
@leahwicz leahwicz deleted the leahwicz/backport4512 branch December 20, 2021 15:02
@anthu anthu mentioned this pull request Dec 22, 2021
Merged
4 tasks
@aranke aranke mentioned this pull request May 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leahwicz @gshank @jtcohen6