Use new agate_helper.Number type in tests for table creation #76
Conversation
|
@anthu Thank you so much for working taking the initiative on this fix, we've actually been making fixes for this in other repos as well noted https://github.com/dbt-labs/dbt-bigquery/pull/93/files and dbt-labs/dbt-redshift#58 would love to keep these implementations uniform for future maintenance. |
|
Hey @McKnight-42, Yeah, I saw your work in the mentioned PRs earlier today and I like your approach! |
|
@anthu if you could adapt yours to the way the others are i can review as soon as tomorrow and we can merge then, i tested it locally on redshift and know it passes the tests as well so should have no issues there. don't want to lose this great collaborative record and keeping you as the main contributor for this as you took the initiative seems right. |
* Use new agate_helper.Number type for table creation * Revert "Use new agate_helper.Number type for table creation" This reverts commit 4d72ac7. * Update test of Number type check from Boolean to 0,1
* Use new agate_helper.Number type for table creation * Revert "Use new agate_helper.Number type for table creation" This reverts commit 4d72ac7. * Update test of Number type check from Boolean to 0,1
* Remove unneeded Core download in CI (#127) * Update dev_requirements for 1.0.latest branch * Use new agate_helper.Number type in tests for table creation (#76) * Use new agate_helper.Number type for table creation * Revert "Use new agate_helper.Number type for table creation" This reverts commit 4d72ac7. * Update test of Number type check from Boolean to 0,1 Co-authored-by: Anton Huck <anthu@users.noreply.github.com>
Description
The PR dbt-labs/dbt-core#4512 fixed bool coercion. As part of the change the TypeTester changed the available Number Type from
agate.data_types.number.Numbertoagate_helper.Number.While this is well fine in terms of inheritance the tests are failing now, see:
#74 https://github.com/dbt-labs/dbt-snowflake/runs/4610851479?check_suite_focus=true
#75 https://github.com/dbt-labs/dbt-snowflake/runs/4606768468?check_suite_focus=true
This PR fixes the tests to use the new Number type
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.