Fix the tests (#2317) #2318
Merged
Fix the tests (#2317) #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like a neat interplay between yaml's anchor/pointer notation (it's a reference, not a copy!), and dbt inserting 'model' into the keyword args for tests. I've added a `copy.deepcopy` call to where dbt collects test arguments from the underlying file, so the 'model' is inserted into a fresh keyword arguments dictionary.
Since they apparently will do this in patch releases, pinnned to precisely 2.11.2 But, it means we don't have to override NativeSandboxTemplate.render anymore, so that's nice
|
These tests broke because Jinja2 removed a keyword argument that we used to override I've accordingly locked Jinja's version to 2.11.2, unfortunately it looks like we can't count on it to provide a stable API. |
4 tasks
5 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2317
Description
This looks like a neat interplay between yaml's anchor/pointer notation (it's
a reference, not a copy!), and dbt inserting 'model' into the keyword args for
tests.
I've added a
copy.deepcopycall to where dbt collects test arguments from theunderlying file, so the 'model' is inserted into a fresh keyword arguments
dictionary.
While I was in there, I also removed a method that's not called anymore.
Checklist
This PR includes tests, or tests are not required/relevant for this PRThe tests were already there!I have updated the- I don't think this merits a CHANGELOG update?CHANGELOG.mdand added information about my change to the "dbt next" section.