Feature/compile ls relation caches (#1705) #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you merge |
drewbanin
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
One comment on the diff being funky, but otherwise, this LGTM. On our internal analytics project, this change reduces the dbt compile time from 48s to 28s (not scientific). I think we have some more work to do on this front in the future, but this is a good and positive change in it's own right.
Ship it when the diff is addressed :)
Added the populate_adapter_cache to the GraphRunnableTask before_run method - Previously only Run used it
beckjake
force-pushed
the
feature/compile-ls-relation-caches
branch
from
fca8e28
to
ac427bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1705
Description
Added the populate_adapter_cache to the GraphRunnableTask before_run method
Checklist
This PR includes tests, ortests are not required/relevant for this PRCHANGELOG.mdand added information about my change to the "dbt next" section.