fix subdomain and localhost

[NewFuture]

fix #83
related #79

[NewFuture]

@davewasmer @zetlen please help review and update

[drmcclelland]

@NewFuture does this also fix this error message: Error: "localhost" is not a valid domain name. ?

[NewFuture]

@NewFuture does this also fix this error message: Error: "localhost" is not a valid domain name. ?

No,
but localhost can also be added in this code.

well, this project seems poorly maintained.

[MagnusHJensen]

Would be nice to see this fixed, we also use local as our subdomain, and it's currently broken :/

[jonthenerd]

We're blocked on updating devcert to v1.2.1 due to the issue w/localhost. GitHub Dependabot currently reports vulnerabilities under v1.2.1 (see https://www.cvedetails.com/cve/CVE-2022-1929/). Is there any ETA from the maintainers @davewasmer ? on when this could be reviewed and merged? I'm sure we're not the only ones that use devcert to provide localhost an SSL cert to use for localized development...

[mlusk-cdm]

We have a similar issue. localhost is used testing locally. We use docker containers for integration testing with selenium-grid so we use the container name like 'test-container' for talking between containers. devcert does not like localhost or 'test-container' anymore as it considers them invalid.

[NewFuture]

@drmcclelland @jonthenerd @mlusk-cdm
I update the pr to support localhost.

[zetlen]

Thanks all. Folks, I'm sorry about the delay; I'm working on a modern drop-in replacement for this library and I simply haven't kept up.

I really appreciate @NewFuture for opening the PR and responding to others' comments. I'll release this shortly.

[jonthenerd]

Thanks @zetlen . Glad this lib is still being maintained and that you're around. Got a link to your in-progress work?