Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create certificate for local.domain.com #83

Closed
amiryonatan opened this issue May 4, 2022 · 4 comments · Fixed by #84
Closed

Unable to create certificate for local.domain.com #83

amiryonatan opened this issue May 4, 2022 · 4 comments · Fixed by #84

Comments

@amiryonatan
Copy link

Since version 1.2.1, we're getting an error:

Error: "local.domain.com" is not a valid domain name.
    at /Users/amiry/dev/editor-x/bundles/editorx-santa-editor-bridge/node_modules/devcert/dist/index.js:40:23
    at Array.forEach (<anonymous>)
@mcalthrop-lego
Copy link

@amiryonatan The latest release uses an external npm package for determining validity of a domain name, and subdomains have been explicitly disallowed.

I'm not sure of the reason for this; see my comment here: #79 (comment)

@rowong
Copy link

rowong commented May 4, 2022

The change also appears to have busted generating certs for "localhost". We are seeing the following error:

UnhandledPromiseRejectionWarning: Error: "localhost" is not a valid domain name.
    at /mnt/c/wsl/node_modules/devcert/dist/index.js:40:23
    at Array.forEach (<anonymous>)

@NewFuture
Copy link
Contributor

patch a fix pr #84 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@NewFuture @rowong @amiryonatan @mcalthrop-lego and others