Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: pin devcert to 1.2.0 #3118

Merged
merged 1 commit into from May 10, 2022
Merged

Project: pin devcert to 1.2.0 #3118

merged 1 commit into from May 10, 2022

Conversation

eatyourgreens
Copy link
Contributor

Downgrade devcert to 1.2.0 so that we can run a local development server again.

Package

app-project

Linked Issue and/or Talk Post

davewasmer/devcert#83

@eatyourgreens
Project: pin devcert to 1.2.0
57db34f 
Downgrade devcert to 1.2.0 so that we can run a local development server again.
@eatyourgreens eatyourgreens added the dependencies Pull requests that update a dependency file label May 10, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.988% when pulling 57db34f on pin-devcert into ea85166 on master.

mcbouslog
mcbouslog approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed issue on master, confirmed issue fixed with devcert pinned to v1.2.0 on this branch.

@github-actions github-actions bot added the approved This PR is approved for merging label May 10, 2022
@eatyourgreens eatyourgreens merged commit 1dc31a6 into master May 10, 2022
@eatyourgreens eatyourgreens deleted the pin-devcert branch May 10, 2022 15:55
@eatyourgreens eatyourgreens mentioned this pull request Dec 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbouslog mcbouslog mcbouslog approved these changes

@shaunanoordin shaunanoordin Awaiting requested review from shaunanoordin

@goplayoutside3 goplayoutside3 Awaiting requested review from goplayoutside3

Assignees
No one assigned
Labels
approved This PR is approved for merging dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eatyourgreens @coveralls @mcbouslog