Revert "Revert "Remove chardet version upper limit"" #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 09cb41c. Original PR which removed upper bound: datalad#7029 Debians now have 5.1.0, and we can't package while demanding an outdated chardet. Let's see again if we really need to limit upper version.
yarikoptic
added
semver-dependencies
github-actions
bot
removed
the
CHANGELOG-missing
Codecov ReportBase: 88.72% // Head: 90.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint #7263 +/- ##
==========================================
+ Coverage 88.72% 90.70% +1.98%
==========================================
Files 326 326
Lines 44423 44423
Branches 5919 5919
==========================================
+ Hits 39415 40296 +881
+ Misses 4993 4112 -881
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
all tests pass, debian build also passed. Let's merge. Third time is a charm, right? |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 09cb41c. Original PR which removed upper bound:
#7029
Debians now have 5.1.0, and we can't package while demanding an outdated chardet. Let's see again if we really need to limit upper version.