Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen chardet upper version limit #7256

Closed
sanjayankur31 opened this issue Jan 13, 2023 · 2 comments
Closed

Loosen chardet upper version limit #7256

sanjayankur31 opened this issue Jan 13, 2023 · 2 comments

Comments

@sanjayankur31
Copy link

I see that chardet was set to <5 because requests didn't support it before:

0c88872

however, the latest versions of requests pins chardet to <6, implying that it does support version 5. So the chardet dep can also be bumped here.

psf/requests@73793ce
@kimsin98
Copy link
Contributor

Addressed with #7263!

@adswa
Copy link
Member

adswa commented Jan 19, 2023

thx all!

@adswa adswa closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanjayankur31 @kimsin98 @adswa