Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespell: adding config, workflow and fixing some typos #336

Merged
merged 9 commits into from Feb 28, 2023

Conversation

yarikoptic
Copy link
Member

In the excitement of coming up hackathon and also since datalad/datalad-extension-template#45 has been debated for nearly half a year, decided to make at least this one a little more a better spelled one ;)

@yarikoptic
Copy link
Member Author

I don't see how these type fixes could result in appveyor fails like


>           raise AssertionError("dicts differ:\n%s" % "\n".join(msgs))
E           AssertionError: dicts differ:
E            ['root_dataset_id'] differs: '00010203-1011-2021-3031-404142434445' != '<unknown>'
../../../dlvenv/lib/python3.8/site-packages/datalad/tests/utils_pytest.py:1271: AssertionError

@adswa
Copy link
Member

adswa commented Feb 28, 2023

I have seen these failures also in core in the metalad tests, e.g. in datalad/datalad#7308. It looks like the fix is in https://github.com/datalad/datalad-metalad/pull/333/files and landed in maint - you probably found that already and thus created the merge of maint - thx!

@adswa adswa mentioned this pull request Feb 28, 2023
Copy link
Collaborator

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @yarikoptic

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7944964) 86.42% compared to head (b692ab9) 86.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          88       88           
  Lines        4831     4831           
=======================================
  Hits         4175     4175           
  Misses        656      656           
Impacted Files Coverage Δ
datalad_metalad/__init__.py 100.00% <ø> (ø)
datalad_metalad/aggregate.py 80.53% <ø> (ø)
datalad_metalad/extractors/core.py 79.24% <ø> (ø)
datalad_metalad/extractors/tests/test_base.py 98.33% <ø> (ø)
datalad_metalad/filters/base.py 83.33% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member Author

heh -- codespell is still failing due to fresh? ./docs/source/design/history.rst:75: formate ==> format, will tune up for that now

@adswa adswa merged commit 47d85d4 into datalad:master Feb 28, 2023
@yarikoptic yarikoptic deleted the enh-codespell branch March 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants