Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge maint (0.4.12) #337

Merged
merged 9 commits into from
Feb 28, 2023
Merged

Conversation

yarikoptic
Copy link
Member

No description provided.

christian-monch and others added 9 commits January 26, 2023 16:59
This commit fixes a bug in which dataset ids were
checked even with un-versioned dataset tree paths
The newly required version fixes the UUID set
issue and some other problems that appeared
when adding aggregated metadata.
include root-dataset and sub-dataset in UUID-set
0.4.12

* tag '0.4.12':
  fix meta-add tests
  update the minimal metadata model version
  check dataset ids only if necessary
  update MacOS test definitions
  do not try to dump a None-MRR
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Base: 86.50% // Head: 86.42% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (c3115ab) compared to base (5c4e165).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   86.50%   86.42%   -0.09%     
==========================================
  Files          88       88              
  Lines        4825     4831       +6     
==========================================
+ Hits         4174     4175       +1     
- Misses        651      656       +5     
Impacted Files Coverage Δ
datalad_metalad/dump.py 74.05% <50.00%> (-2.58%) ⬇️
datalad_metalad/add.py 91.91% <100.00%> (+0.03%) ⬆️
datalad_metalad/tests/test_add.py 99.72% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adswa
Copy link
Member

adswa commented Feb 28, 2023

Side note: Merging maint will fix/prevent the test failures arising in e.g., #336

@christian-monch christian-monch merged commit 5c5c654 into datalad:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants