-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict bokeh=3
support
#7329
Restrict bokeh=3
support
#7329
Conversation
Hmm clearly the mocking I added doesn't work when other tests have run before it. |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 46m 13s ⏱️ + 9m 14s For more details on these failures, see this check. Results for commit 5e57470. ± Comparison against base commit 69b74f9. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjoseph92
# Remove these imports, so when the scheduler imports | ||
# `distributed.dashboard.scheduler`, it has to re-import `dashboard.core`, which | ||
# is where the bokeh version detection happens at import time, via | ||
# `dashboard.utils.BOKEH_VERSION`. | ||
sys.modules.pop("distributed.dashboard.scheduler", None) | ||
sys.modules.pop("distributed.dashboard.core", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to add this test coverage and figure out the weirdness that was happening with these mock
s not originally working as expected (when the entire test suite was run). It's good to see things working, but I will say the logic here looks a bit brittle and it would be good to simplify if possible. Let's include things here as they are, since they work, and will help us get the release out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, it's highly brittle (as evidenced by it working the first time but failing when run in CI). Since all this logic happens at import time, brittle mocks are kind of the only option—we'd probably want to refactor things into a function, so patching it is much more predictable.
See discussion in #7327
bokeh=3
#5648< 3
back into error messagespre-commit run --all-files