Remove np.float in PyTest and skip new NumPy failures
#977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahyurick
requested review from
ayushdg,
charlesbluca and
galipremsagar
as code owners
sarahyurick
commented
Dec 21, 2022
| @@ -924,6 +925,7 @@ def test_experiment_automl_classifier(c, client, training_df): | |||
|
|
|||
| # TODO - many ML tests fail on clusters without sklearn - can we avoid this? | |||
| @skip_if_external_scheduler | |||
| @pytest.mark.skip(reason="Waiting on https://github.com/EpistasisLab/tpot/pull/1280") | |||
There was a problem hiding this comment.
TPOT fails with the newest NumPy version as well. I've opened EpistasisLab/tpot#1280 to resolve this.
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
==========================================
- Coverage 77.70% 77.34% -0.37%
==========================================
Files 75 75
Lines 4235 4233 -2
Branches 772 765 -7
==========================================
- Hits 3291 3274 -17
- Misses 774 783 +9
- Partials 170 176 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sarahyurick
commented
Dec 21, 2022
| @@ -140,6 +141,8 @@ def test_literal_null(c): | |||
| assert_eq(df, expected_df) | |||
|
|
|||
|
|
|||
| # TODO - https://github.com/dask-contrib/dask-sql/issues/978 | |||
| @skip_if_external_scheduler | |||
| def test_random(c): | |||
sarahyurick
changed the title
np.float in PyTestnp.float in PyTest and skip new NumPy failures
ayushdg
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 1.24.0 removed the
np.floatalias, so we have to replacenp.floatwithnp.float64in PyTesttest_custom_function_row_two_args.Another option is to replace
np.floatwith Python'sfloat, although the NumPy version may be useful for consistency with NumPy arrays (source).