Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix test_random on Dask cluster #978

Closed
sarahyurick opened this issue Dec 21, 2022 · 3 comments
Closed

[BUG] Fix test_random on Dask cluster #978

sarahyurick opened this issue Dec 21, 2022 · 3 comments
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer

Comments

@sarahyurick
Copy link
Collaborator

Right now, test_random fails on our Dask cluster integration test with a TypeError: __randomstate_ctor() takes from 0 to 1 positional arguments but 2 were given.

Like #977, I think this may have to do with the newest NumPy version release.

See also the definition of __randomstate_ctor in the NumPy source code.
@sarahyurick sarahyurick added bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer labels Dec 21, 2022
@sarahyurick sarahyurick mentioned this issue Dec 21, 2022
Merged
@sarahyurick
Copy link
Collaborator Author

sarahyurick commented Jan 4, 2023 •
edited

Can't really seem to trace this to anything on our end. From the logs, it seems like the error is raised here https://github.com/dask/distributed/blob/64a7caebd5993dac381c747e8aa499528b0ca4ee/distributed/client.py#L2157, but beyond that I'm having trouble tracing the error.

Also, __randomstate_ctor is associated with pickling, which may be useful for debugging. But right now, I'm not really sure how to go about fixing this ¯_(ツ)_/¯ might make sense to just wait until other libraries like Dask Distributed are updated to handle the latest NumPy changes.

@sarahyurick
Copy link
Collaborator Author

dask/distributed#7423 is one such example.

@sarahyurick
Copy link
Collaborator Author

Closed via #867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sarahyurick