Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use : as builder key separator in docs #3294

Merged
merged 1 commit into from May 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion _test/pkgs/provides_builder/build.yaml
Expand Up @@ -5,7 +5,7 @@ builders:
build_extensions: {".dart": [".something.dart"]}
auto_apply: dependents
applies_builders:
- provides_builder|some_post_process_builder
- provides_builder:some_post_process_builder
some_not_applied_builder:
import: "package:provides_builder/builders.dart"
builder_factories: ["notApplied"]
Expand Down
2 changes: 1 addition & 1 deletion _test/test/build_integration_test.dart
Expand Up @@ -94,7 +94,7 @@ void main() {
final dartSource =
File(p.join('build', 'web', 'packages', '_test', 'app.dart'));
await runBuild(trailingArgs: [
'--define=build_web_compilers|dart_source_cleanup=enabled=true',
'--define=build_web_compilers:dart_source_cleanup=enabled=true',
'--output',
'build'
]);
Expand Down
4 changes: 2 additions & 2 deletions _test/test/serve_integration_test.dart
Expand Up @@ -148,7 +148,7 @@ void main() {
'--build-filter',
'web/sub/main.dart.js',
'--define',
'build_web_compilers|ddc=environment={"message": "goodbye"}',
'build_web_compilers:ddc=environment={"message": "goodbye"}',
]);

addTearDown(() async {
Expand Down Expand Up @@ -177,7 +177,7 @@ void main() {
'web/sub/main.dart.js',
'--verbose',
'--define',
'build_web_compilers|ddc=generate-full-dill=true',
'build_web_compilers:ddc=generate-full-dill=true',
]);

addTearDown(() async {
Expand Down
6 changes: 3 additions & 3 deletions build_runner_core/lib/src/generate/phase.dart
Expand Up @@ -197,10 +197,10 @@ String _builderLabel(Object builder) {
return label;
}

/// Change "angular|angular" to "angular".
/// Change "angular:angular" to "angular".
String _simpleBuilderKey(String builderKey) {
if (!builderKey.contains('|')) return builderKey;
var parts = builderKey.split('|');
if (!builderKey.contains(':')) return builderKey;
var parts = builderKey.split(':');
if (parts[0] == parts[1]) return parts[0];
return builderKey;
}
Expand Down
2 changes: 2 additions & 0 deletions build_vm_compilers/CHANGELOG.md
@@ -1,3 +1,5 @@
## 1.0.12-dev

## 1.0.11

- Allow the latest analyzer
Expand Down
2 changes: 1 addition & 1 deletion build_vm_compilers/README.md
Expand Up @@ -54,7 +54,7 @@ builder applications to what you already have, sometime after the
`build_modules` builder applications:

```dart
apply('build_vm_compilers|entrypoint',
apply('build_vm_compilers:entrypoint',
[vmKernelEntrypointBuilder], toRoot(),
hideOutput: true,
// These globs should match your entrypoints only.
Expand Down
4 changes: 2 additions & 2 deletions build_vm_compilers/build.yaml
Expand Up @@ -14,7 +14,7 @@ builders:
is_optional: True
auto_apply: none
required_inputs: [".dart", ".module.library"]
applies_builders: ["build_modules|module_cleanup"]
applies_builders: ["build_modules:module_cleanup"]
vm:
import: "package:build_vm_compilers/builders.dart"
builder_factories:
Expand All @@ -28,7 +28,7 @@ builders:
- .dart
- .vm.module
applies_builders:
- build_vm_compilers|modules
- build_vm_compilers:modules
entrypoint:
import: "package:build_vm_compilers/builders.dart"
builder_factories:
Expand Down
2 changes: 1 addition & 1 deletion build_vm_compilers/pubspec.yaml
@@ -1,5 +1,5 @@
name: build_vm_compilers
version: 1.0.11
version: 1.0.12-dev
description: Builder implementations wrapping Dart VM compilers.
repository: https://github.com/dart-lang/build/tree/master/build_vm_compilers

Expand Down
2 changes: 2 additions & 0 deletions build_web_compilers/CHANGELOG.md
@@ -1,3 +1,5 @@
## 3.2.4-dev

## 3.2.3

- Allow analyzer 4.x.
Expand Down
12 changes: 6 additions & 6 deletions build_web_compilers/build.yaml
Expand Up @@ -45,7 +45,7 @@ builders:
is_optional: True
auto_apply: none
required_inputs: [".dart", ".module.library"]
applies_builders: ["build_modules|module_cleanup"]
applies_builders: ["build_modules:module_cleanup"]
ddc_modules:
import: "package:build_web_compilers/builders.dart"
builder_factories:
Expand All @@ -61,7 +61,7 @@ builders:
is_optional: True
auto_apply: none
required_inputs: [".dart", ".module.library"]
applies_builders: ["build_modules|module_cleanup"]
applies_builders: ["build_modules:module_cleanup"]
ddc:
import: "package:build_web_compilers/builders.dart"
builder_factories:
Expand Down Expand Up @@ -90,11 +90,11 @@ builders:
required_inputs:
- .ddc.module
applies_builders:
- build_web_compilers|ddc_modules
- build_web_compilers:ddc_modules
# This isn't really the best place to apply these, but it is the only
# place we can (its the only builder which runs on all packages).
- build_web_compilers|dart2js_modules
- build_web_compilers|dart_source_cleanup
- build_web_compilers:dart2js_modules
- build_web_compilers:dart_source_cleanup
entrypoint:
import: "package:build_web_compilers/builders.dart"
builder_factories:
Expand Down Expand Up @@ -134,7 +134,7 @@ builders:
release_options:
compiler: dart2js
applies_builders:
- build_web_compilers|dart2js_archive_extractor
- build_web_compilers:dart2js_archive_extractor
_stack_trace_mapper_copy:
import: "tool/copy_builder.dart"
builder_factories:
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
@@ -1,5 +1,5 @@
name: build_web_compilers
version: 3.2.3
version: 3.2.4-dev
description: Builder implementations wrapping Dart compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers

Expand Down
4 changes: 2 additions & 2 deletions docs/build_yaml_format.md
Expand Up @@ -126,5 +126,5 @@ default target in the current package (which has the same name as the package).
An identifier for a `builder`. A builder has two parts, a `package` and a
`name`.

To construct a key, you join the package and name with a `|`, so for instance
the `bar` builder in the `foo` package would be referenced like this `foo|bar`.
To construct a key, you join the package and name with a `:`, so for instance
the `bar` builder in the `foo` package would be referenced like this `foo:bar`.