Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use : as builder key separator in docs #3294

Merged
merged 1 commit into from May 2, 2022
Merged

Use : as builder key separator in docs #3294

merged 1 commit into from May 2, 2022

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented May 2, 2022

Closes #3293

The character was originally | but was changed to : because the
former is a special character in windows terminals. Some docs where
updated with that change, but some were missed.

Use : over | consistently in docs, build.yaml, and command line
arguments in tests.

Fix a utility which shortens redundant builder names to use the new
separator. This utility had not been working.

Closes #3239

The character was originally `|` but was changed to `:` because the
former is a special character in windows terminals. Some docs where
updated with that change, but some were missed.

Use `:` over `|` consistently in docs, `build.yaml`, and command line
arguments in tests.

Fix a utility which shortens redundant builder names to use the new
separator. This utility had not been working.
@natebosch natebosch requested a review from jakemac53 May 2, 2022 18:35
@natebosch natebosch merged commit 04e5357 into master May 2, 2022
@natebosch natebosch deleted the pipe-to-colon branch May 2, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent docs about builder key in builder configuration (build.yaml)
2 participants