Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

await a missed test failure, fix broken test #3245

Merged
merged 2 commits into from Feb 16, 2022
Merged

await a missed test failure, fix broken test #3245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dd838b
await a missed test failure, skip broken test
natebosch Feb 15, 2022
4ae50fa
Find an ambiguous element
natebosch Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 14 additions & 10 deletions build_resolvers/test/resolver_test.dart
View file
Open in desktop
Expand Up @@ -397,25 +397,29 @@ void main() {
}, resolvers: AnalyzerResolvers());
});

test('assetIdForElement throws for ambigious elements', () {
test('assetIdForElement throws for ambiguous elements', () {
return resolveSources({
'a|lib/a.dart': '''
import 'b.dart';
import 'c.dart';

class SomeClass {}

main() {
SomeClass();
} ''',
@SomeClass()
main() {}
''',
'a|lib/b.dart': '''
class SomeClass {}
''',
'a|lib/c.dart': '''
class SomeClass {}
''',
}, (resolver) async {
var entry = await resolver.libraryFor(AssetId('a', 'lib/a.dart'));
var classDefinition = entry.importedLibraries
.map((l) => l.getType('SomeClass'))
.singleWhere((c) => c != null)!;
expect(() => resolver.assetIdForElement(classDefinition),
final element = entry.topLevelElements
.firstWhere((e) => e is FunctionElement && e.name == 'main')
.metadata
.single
.element!;
await expectLater(() => resolver.assetIdForElement(element),
throwsA(isA<UnresolvableAssetException>()));
}, resolvers: AnalyzerResolvers());
});
Expand Down